[Console] fix typo in phpdoc #27777
Merged
[Console] fix typo in phpdoc #27777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Tobion
commented
Jun 29, 2018
•
| Q | A |
|---|---|
| Branch? | 4.1 (#26847) |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| @@ -42,7 +42,7 @@ public function write($messages, $newline = false, $options = 0); | |||
| /** | |||
| * Writes a message to the output and adds a newline at the end. | |||
| * | |||
| * @param string|iterable $messages The message as an iterable of lines of a single string | |||
| * @param string|iterable $messages The message as an iterable of lines or a single string | |||
There was a problem hiding this comment.
In this case the strings are output as lines (writeLn). But I don't mind to change it as well if you want.
There was a problem hiding this comment.
I agree with this suggestion too.
There was a problem hiding this comment.
Re-reading, I'd prefer to keep "lines" above, don't you think?
There was a problem hiding this comment.
I think I prefer talking about php types only, but no strong opinion really.
7c155cb to
a5295ad
Compare
a5295ad to
7aa4557
Compare
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Console] fix typo in phpdoc | Q | A | ------------- | --- | Branch? | 4.1 (#26847) | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 7aa4557 [Console] fix typo in phpdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.