Skip to content

[Security] Use AuthenticationTrustResolver in SimplePreAuthenticationListener #27798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 4, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes (minor)
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Minor, but would be consistent with how ContextListener checks for anonymous tokens.

Copy link
Contributor

@linaori linaori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there more cases like this within Symfony, also for the Remember me?

@nicolas-grekas
Copy link
Member Author

Just checked: none.

@chalasr
Copy link
Member

chalasr commented Jul 4, 2018

Thank you @nicolas-grekas.

@chalasr chalasr merged commit 27b89cb into symfony:master Jul 4, 2018
chalasr pushed a commit that referenced this pull request Jul 4, 2018
…eAuthenticationListener (nicolas-grekas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[Security] Use AuthenticationTrustResolver in SimplePreAuthenticationListener

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes (minor)
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Minor, but would be consistent with how `ContextListener` checks for anonymous tokens.

Commits
-------

27b89cb [Security] Use AuthenticationTrustResolver in SimplePreAuthenticationListener
@nicolas-grekas nicolas-grekas deleted the sec-trust branch July 4, 2018 09:09
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
This was referenced Nov 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants