[Serializer] Fix serialization of items with groups across entities and discrimination map #27826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failures are un-related. |
|
This PR works well and fix my problem, thanks. |
Closed
stof
reviewed
Jul 3, 2018
| @@ -142,11 +142,16 @@ protected function getAllowedAttributes($classOrObject, array $context, $attribu | |||
| return false; | |||
| } | |||
|
|
|||
| if (null !== $this->classDiscriminatorResolver && null !== $discriminatorMapping = $this->classDiscriminatorResolver->getMappingForMappedObject($classOrObject)) { | |||
| $allowedAttributes[] = $attributesAsString ? $discriminatorMapping->getTypeProperty() : new AttributeMetadata($discriminatorMapping->getTypeProperty()); | |||
| $class = is_object($classOrObject) ? \get_class($classOrObject) : $classOrObject; | |||
There was a problem hiding this comment.
is_object should be fully-qualified here, to benefit from the optimized opcode.
There was a problem hiding this comment.
btw, shouldn't it go inside the if (null !== $this->classDiscriminatorResolver) { ?
There was a problem hiding this comment.
Good points, updated 👍
65e0370 to
c648b93
Compare
|
@nicolas-grekas the fixture update covers the use-cases I think about so I'd say no 🤔 |
dunglas
approved these changes
Jul 9, 2018
|
Thank you @sroze. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
… entities and discrimination map (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Fix serialization of items with groups across entities and discrimination map | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27816, #27641 | License | MIT | Doc PR | ø I believe this approach is better than the one taken in #27816. At least, it's an alternative :) Commits ------- c648b93 Fix serialization of abstract items with groups across multiple entities
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this approach is better than the one taken in #27816. At least, it's an alternative :)