[Console] changed warning verbosity; fixes typo #27858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Jul 5, 2018
| @@ -220,7 +220,10 @@ public function run(InputInterface $input, OutputInterface $output) | |||
| if (function_exists('cli_set_process_title')) { | |||
| if (!@cli_set_process_title($this->processTitle)) { | |||
| if ('Darwin' === PHP_OS) { | |||
| $output->writeln('<comment>Running "cli_get_process_title" as an unprivileged user is not supported on MacOS.</comment>'); | |||
| $output->writeln( | |||
There was a problem hiding this comment.
Usually we keep everything on a single line.
There was a problem hiding this comment.
k. wasn't sure about line lengths.
javiereguiluz
approved these changes
Jul 6, 2018
There was a problem hiding this comment.
It makes sense to me. Thanks @adrian-enspired!
(and please, put the new code in a single line ... even if it's long. thanks!).
xabbuh
approved these changes
Jul 6, 2018
chalasr
approved these changes
Jul 6, 2018
|
Thank you for this first contribution @adrian-enspired! |
chalasr
pushed a commit
that referenced
this pull request
Jul 6, 2018
…enspired) This PR was merged into the 4.2-dev branch. Discussion ---------- [Console] changed warning verbosity; fixes typo | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes* | Fixed tickets | n/a | License | MIT | Doc PR | n/a * Tests pass, but I do not have an installation of MacOS to run tests on. Tests should be unaffected (the test is simply [skipped on MacOS](https://github.com/symfony/console/blob/master/Tests/Command/CommandTest.php#L345)). When a Console Command fails to change the process title on MacOS, a warning is issued to output. This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing. This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage. I've also fixed a typo in the message ("get" vs. "set"). Commits ------- 86c771a changed warning verbosity; fixes typo
chalasr
pushed a commit
that referenced
this pull request
Jul 6, 2018
…enspired) This PR was merged into the 4.2-dev branch. Discussion ---------- [Console] changed warning verbosity; fixes typo | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes* | Fixed tickets | n/a | License | MIT | Doc PR | n/a * Tests pass, but I do not have an installation of MacOS to run tests on. Tests should be unaffected (the test is simply [skipped on MacOS](https://github.com/symfony/console/blob/master/Tests/Command/CommandTest.php#L345)). When a Console Command fails to change the process title on MacOS, a warning is issued to output. This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing. This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage. I've also fixed a typo in the message ("get" vs. "set"). Commits ------- 86c771a changed warning verbosity; fixes typo
|
Backported on 2.8 in ddea90e |
|
Seems the lowest branch was actually 2.7. rebasing had a lot of conflicts, so I made a new branch + PR instead: Should I close this in favor of that PR? edit I posted this before seeing the more recent comments. closing my other! |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
* 2.8: [Console] fix CS improve deprecation messages minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired)
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
* 3.4: [Console] fix CS [OptionResolver] resolve arrays [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output [PropertyInfo] Fix dock block lookup fallback loop [HttpFoundation] don't encode cookie name for BC improve deprecation messages minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired) AppBundle->App. [DI] Fix dumping ignore-on-uninitialized references to synthetic services
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
* 4.0: [Console] fix CS [OptionResolver] resolve arrays [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output [PropertyInfo] Fix dock block lookup fallback loop [HttpFoundation] don't encode cookie name for BC improve deprecation messages minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired) AppBundle->App. [DI] Fix dumping ignore-on-uninitialized references to synthetic services
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
* 4.1: [Console] fix CS [OptionResolver] resolve arrays [TwigBridge] Fix missing path and separators in loader paths list on debug:twig output [PropertyInfo] Fix dock block lookup fallback loop [FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes() [HttpFoundation] don't encode cookie name for BC improve deprecation messages minor #27858 [Console] changed warning verbosity; fixes typo (adrian-enspired) AppBundle->App. [Workflow] Fixed BC break [DI] Fix dumping ignore-on-uninitialized references to synthetic services
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Console Command fails to change the process title on MacOS, a warning is issued to output. This warning is relevant to developers of Console applications, but to end users is largely meaningless and potentially confusing.
This PR changes the verbosity of the warning to "very verbose" so it does not interrupt normal usage.
I've also fixed a typo in the message ("get" vs. "set").