[Routing] deprecate non string requirement names #27879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An alternative solution could be to catch such cases in the annotation loader and provide a meaningful error/warning message. |
7f836be to
746f38b
Compare
746f38b to
8bb5266
Compare
stof
approved these changes
Jul 9, 2018
fabpot
approved these changes
Jul 9, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 11, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [Routing] deprecate non string requirement names | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Basically, this will help catching wrong `@Route` annotation configurations like the following which can lead to hard to debug issues: ```php @route("/{foo}", requirements={"foo", "bar"}) ``` Commits ------- 8bb5266 deprecate non string requirement names
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, this will help catching wrong
@Routeannotation configurations like the following which can lead to hard to debug issues: