Skip to content

Mock date() in ClockMock #27890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Bridge/PhpUnit] Mock date() in ClockMock
As to the PHP documentation date() uses the value of time() as timestamp
if none is given. date() has to be mocked in ClockMock as well for this
still being true, otherwise \time() is used as default.
  • Loading branch information
Dominic Tubach committed Jul 9, 2018
commit e8ba79adb9f6e81f3417bbde2a0635277899e69c
15 changes: 15 additions & 0 deletions src/Symfony/Bridge/PhpUnit/ClockMock.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

/**
* @author Nicolas Grekas <p@tchwork.com>
* @author Dominic Tubach <dominic.tubach@to.com>
*/
class ClockMock
{
Expand Down Expand Up @@ -69,6 +70,15 @@ public static function microtime($asFloat = false)
return sprintf('%0.6f %d', self::$now - (int) self::$now, (int) self::$now);
}

public static function date($format, $timestamp = null)
{
if (null === $timestamp) {
$timestamp = self::time();
}

return \date($format, $timestamp);
}

public static function register($class)
{
$self = get_called_class();
Expand Down Expand Up @@ -107,6 +117,11 @@ function usleep(\$us)
return \\$self::usleep(\$us);
}

function date(\$format, \$timestamp = null)
{
return \\$self::date(\$format, \$timestamp);
}

EOPHP
);
}
Expand Down
65 changes: 65 additions & 0 deletions src/Symfony/Bridge/PhpUnit/Tests/ClockMockTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
<?php

/*
* This file is part of the Symfony package.
*
* (c) Fabien Potencier <fabien@symfony.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/

namespace Symfony\Bridge\PhpUnit\Tests;

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\PhpUnit\ClockMock;

/**
* @author Dominic Tubach <dominic.tubach@to.com>
*
* @covers \Symfony\Bridge\PhpUnit\ClockMock
*/
class ClockMockTest extends TestCase
{
public static function setUpBeforeClass()
{
ClockMock::register(__CLASS__);
}

protected function setUp()
{
ClockMock::withClockMock(1234567890.125);
}

public function testTime()
{
$this->assertSame(1234567890, time());
}

public function testSleep()
{
sleep(2);
$this->assertSame(1234567892, time());
}

public function testMicrotime()
{
$this->assertSame('0.125000 1234567890', microtime());
}

public function testMicrotimeAsFloat()
{
$this->assertSame(1234567890.125, microtime(true));
}

public function testUsleep()
{
usleep(2);
$this->assertSame(1234567890.125002, microtime(true));
}

public function testDate()
{
$this->assertSame('1234567890', date('U'));
}
}