Hey, I'd appreciate if you can check how this fares against latest dev-master of monolog. Interfaces are now considered stable and while there are a few things I still want to look at before releasing, I'm trying to wrap up soon (and definitely before Symfony 4.3). I'd like to make sure it won't prevent Symfony projects from upgrading before I tag anything though.

* SwiftMailerHandler is broken with Monolog 2 and php 7.1.

what is broken here ?

Hey, I'd appreciate if you can check how this fares against latest dev-master of monolog.

@Seldaek I can look into this on the weekend.

what is broken here ?

@stof see this comment

I've updated the PR for the latest master of Monolog.

I've updated the PR during the EU-FOSSA hackathon. With my modifications, I was able to integrate Monolog 2 into a Symfony 4 application.

@Seldaek Have you ever considered making php 7.2 a requirement for Monolog 2? That would save us quite some pain here. 😅

I already bumped from 7.0 to 7.1.. I am not sure what the 7.2 change would help with, but I feel like that's a bit much. I really need to get there with finalizing monolog 2 though :/

@Seldaek PHP 7.2 is less strict than PHP 7.1 about adding/removing typehints in child classes for some cases. See the PR description.

Ok well I guess it could be considered as the release was delayed so much anyway.. But it means it won't be compatible with Symfony 4 requirements at all then.

Since it does not look like this will be merged into 4.3 anymore: I would suggest to rebase the patch against master, set all handlers to final and apply the interface changes required for Monolog 2. That would mean that version 5.0 of the bridge would be compatible with Monolog 1 and 2 while the Bridge 4.4 would support Monolog 1 only.

@derrabus if 4.4 is not an option then I guess this sounds good. I will try and push for a 2.0 again.. sorry for the delay.

Sorry my comment above was regarding the symfony 5/4 note, but regarding monolog requiring php 7.2 I am still not 100% sure. Will need to think about it some more. I'll add an issue too to see if anyone has feedback.

I've updated the PR for master. It should be safe to merge now.

regarding monolog requiring php 7.2 I am still not 100% sure.

If we made Monolog 2 support a Symfony-5-only feature, the php requirement of Monolog would not matter anymore because Symfony 5 itself will require php 7.2.

Looks all good to me from a quick glance..

There's no way to M2 compatible with SF4.4, right?
This means M1 should accept bug fixes for 3-4 more years ideally.

I think it was mostly possible, at least if you are on php 7.2, if not I think then there was a hack needed for swiftmailer handler? @derrabus probably has more of an overview..

I'd definitely prefer having Symfony 4.4 support Monolog 2 as well, but regardless Monolog 1 is super stable at this point so keeping maintenance up for a few more years is not that much work.

Thank you @derrabus.

There's no way to M2 compatible with SF4.4, right?

Monolog 2 forces us to add return types to several classes. That is a BC break if userland code extends classes from the Monolog bridge. If we wanted to have Monolog 2 in Symfony 4.4, we could either…

• deprecate the affected classes and introduce new ones with return types or…
• document the BC break and pray that userland code does not extend the bridge classes.

• or conditionally load an implementation with types when PHP 7.2 is used. but let's make things simple for now at least - until someone explains why the current way is not enough.