[Routing] Add fallback to cultureless locale for internationalized routes #27957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a1b44cd to
3ae6eaa
Compare
fancyweb
commented
Jul 15, 2018
| @@ -46,8 +46,8 @@ protected function setUp() | |||
|
|
|||
| $this->routeCollection = new RouteCollection(); | |||
| $this->generatorDumper = new PhpGeneratorDumper($this->routeCollection); | |||
| $this->testTmpFilepath = sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.php'; | |||
| $this->largeTestTmpFilepath = sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.large.php'; | |||
| $this->testTmpFilepath = sys_get_temp_dir().\DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.php'; | |||
There was a problem hiding this comment.
These changes were applied by the fabbot patch. I guess I should revert them ?
3ae6eaa to
bd5dc07
Compare
bd5dc07 to
bb9ccbf
Compare
nicolas-grekas
approved these changes
Jul 23, 2018
|
@nicolas-grekas Great job on making this shorter ! Is there any performance impact to "reprocess" everything everytime you generate an url ? |
the only impact this can have are at most two extra calls to strstr. I think that's OK :) |
|
(please fix fabbot issues) |
bb9ccbf to
fd2e3c3
Compare
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 10, 2018
…nationalized routes (fancyweb) This PR was merged into the 4.2-dev branch. Discussion ---------- [Routing] Add fallback to cultureless locale for internationalized routes | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27938 | License | MIT | Doc PR | symfony/symfony-docs#10108 Please check the related issue for the context. TODO : - [x] Update CHANGELOG - [x] Update documentation Commits ------- fd2e3c3 [Routing] Add fallback to cultureless locale for internationalized routes
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 4, 2018
…s (Thomas Calvet, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Routing] Add locale fallback to internationalized routes Related PR : symfony/symfony#27957 Commits ------- 02cc739 Minor reword c15df9d [Routing] Add locale fallback to internationalized routes
|
Thanks from me as well. |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check the related issue for the context.
TODO :