[FrameworkBundle] add missing XSD entry for taggable cache pools #27968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Jul 16, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
fabpot
approved these changes
Jul 16, 2018
stof
reviewed
Jul 16, 2018
| @@ -265,6 +265,7 @@ | |||
| <xsd:complexType name="cache_pool"> | |||
| <xsd:attribute name="name" type="xsd:string" use="required" /> | |||
| <xsd:attribute name="adapter" type="xsd:string" /> | |||
| <xsd:attribute name="tags" type="xsd:string" /> | |||
There was a problem hiding this comment.
isn't it actually a boolean node ?
There was a problem hiding this comment.
Hm, it can indeed be a boolean. But also a service ID: #26934 (comment)
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 16, 2018
… pools (xabbuh) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] add missing XSD entry for taggable cache pools | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- d59cf77 add missing XSD entry for taggable cache pools
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.