[FileValidator] Format file size in validation message according to binaryFormat option #27970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not very proud of how i changed the tests, i think i used a dirty trick. |
f48001d to
e34d9a3
Compare
| @@ -57,6 +57,16 @@ protected function tearDown() | |||
| $this->file = null; | |||
| } | |||
|
|
|||
| // Allows the invocation of a private method | |||
| public function invokeMethod($object, $methodName, $params = array()) | |||
There was a problem hiding this comment.
let's do this inline, no need for a method when it is used only once here
e34d9a3 to
8c7c023
Compare
8c7c023 to
45e5084
Compare
45e5084 to
0edbbd3
Compare
fabpot
approved these changes
Sep 4, 2018
|
Thank you @jfredon. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
…ording to binaryFormat option (jfredon) This PR was merged into the 2.8 branch. Discussion ---------- [FileValidator] Format file size in validation message according to binaryFormat option | Q | A | ------------- | --- | Branch? | 2.8 up to master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27682 | License | MIT | Doc PR | The binaryFormat option of the constraint is not taken into account if the maxsize limit is defined by the php configuration files. This patch correct this inconsistent behavior. If the binaryOption is not set, the unit of measurement used remains in binary because it’s the unit used in php configuration files. Commits ------- 0edbbd3 Format file size in validation message according to binaryFormat option
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binaryFormat option of the constraint is not taken into account if the maxsize limit is defined by the php configuration files.
This patch correct this inconsistent behavior.
If the binaryOption is not set, the unit of measurement used remains in binary because it’s the unit used in php configuration files.