[Security] Remember me: allow to set the samesite cookie flag #27976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Jul 17, 2018
fabpot
approved these changes
Jul 18, 2018
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Jul 18, 2018
…ie flag (dunglas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Security] Remember me: allow to set the samesite cookie flag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? |no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | no | Fixed tickets | no | License | MIT | Doc PR | symfony/symfony-docs#10077 This PR allows to set the [`samesite`](https://www.owasp.org/index.php/SameSite) cookie flag for remember me token cookies. Commits ------- 337e8ef [Security] Remember me: allow to set the samesite cookie flag
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 18, 2018
This PR was merged into the master branch. Discussion ---------- [Security] Remember me: samesite cookie symfony/symfony#27976 Commits ------- eefa182 [Security] Remember me: samesite cookie
This was referenced Nov 3, 2018
Closed
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Mar 23, 2020
…kie flag (dunglas) This PR was merged into the 3.4 branch. Discussion ---------- [Security/Http] Remember me: allow to set the samesite cookie flag | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Similar to #35605, since Chrome 80 is going to require the `samesite` attribute. This is a cherry-pick of #27976 Commits ------- f0ceb73 [Security] Remember me: allow to set the samesite cookie flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to set the
samesitecookie flag for remember me token cookies.