[WebProfilerBundle] Show relative path of the template and improving panel view #27978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Jul 17, 2018
| @@ -0,0 +1,3 @@ | |||
| <svg version="1.1" xmlns="http://www.w3.org/2000/svg" x="0px" y="0px" width="24" height="24" viewBox="0 0 24 24" enable-background="new 0 0 24 24" xml:space="preserve"> | |||
| <path fill="#AAAAAA" d="m8.932327,22.491763c0.015209,-6.448229 -0.971579,-11.295129 -5.994828,-11.618392c4.689807,-0.35251 7.112354,2.633007 9.29714,6.906552c-0.030468,-11.426311 -2.352459,-16.227324 -7.433672,-16.482536c7.433365,0.069108 10.027703,5.898928 11.508208,14.292954c1.170879,-2.282766 3.560547,-5.553431 5.347074,-1.361535c-1.59464,-2.040144 -3.607126,-1.61697 -3.978662,8.261983l-8.744646,0.000107z"/> | |||
There was a problem hiding this comment.
I added a new Twig icon (logo), maybe it could be a good opportunity to use it as the main icon of this panel?
| Before | After |
|---|---|
 |
 |
 |
 |
What do you think?
There was a problem hiding this comment.
Updating the icon sounds good to me.
ro0NL
reviewed
Jul 17, 2018
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/twig.html.twig
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/twig.html.twig
Outdated
Show resolved
Hide resolved
stof
requested changes
Jul 17, 2018
506cd48 to
14f5953
Compare
|
(fabbot.io, AppVeyor and Travis failure aren't related to these changes) Status: Needs Review |
14f5953 to
bcd8058
Compare
ro0NL
reviewed
Jul 17, 2018
fabpot
approved these changes
Jul 18, 2018
|
Thank you @yceruto. |
symfony-splitter
pushed a commit
to symfony/web-profiler-bundle
that referenced
this pull request
Jul 18, 2018
… and improving panel view (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Show relative path of the template and improving panel view | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27911 | License | MIT | Doc PR | - | Before | After | | --- | --- | |  |  | symfony/symfony#27978 (comment): | Before | After | | --- | --- | |  |  |  |  | In addition, I added some visual improvements. Commits ------- bcd8058478 Show relative path of the template and improving panel view
symfony-splitter
pushed a commit
to symfony/twig-bridge
that referenced
this pull request
Jul 18, 2018
… and improving panel view (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Show relative path of the template and improving panel view | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27911 | License | MIT | Doc PR | - | Before | After | | --- | --- | |  |  | symfony/symfony#27978 (comment): | Before | After | | --- | --- | |  |  |  |  | In addition, I added some visual improvements. Commits ------- bcd8058478 Show relative path of the template and improving panel view
fabpot
added a commit
that referenced
this pull request
Jul 18, 2018
… and improving panel view (yceruto) This PR was merged into the 4.2-dev branch. Discussion ---------- [WebProfilerBundle] Show relative path of the template and improving panel view | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27911 | License | MIT | Doc PR | - | Before | After | | --- | --- | |  |  | #27978 (comment): | Before | After | | --- | --- | |  |  |  |  | In addition, I added some visual improvements. Commits ------- bcd8058 Show relative path of the template and improving panel view
|
I missed here a failed test in AppVeyor https://ci.appveyor.com/project/fabpot/symfony/build/1.0.38700#L616 (fixing in #27986) |
fabpot
added a commit
that referenced
this pull request
Jul 19, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- Fix test file relative for AppVeyor | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fix test for AppVeyor introduced in #27978 https://ci.appveyor.com/project/fabpot/symfony/build/1.0.38700#L616 Commits ------- 186a7a9 Fix test file relative for AppVeyor
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27978 (comment):
In addition, I added some visual improvements.