[TwigBridge] Added template "name" argument to debug:twig command to find their paths #27981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e6892ba to
d541670
Compare
b749b99 to
3d246a8
Compare
|
Should it be a dedicated command or an option on the |
|
IMHO the At first I thought about adding it to I'd also like to have everything in one command, but its initial design should change then. I imagine something like this: $ b/c debug:twig # show general info
# proposal 1 (without refactor)
$ b/c debug:twig escape # filter the general info
$ b/c debug:twig --find=@Twig/Exception/error.html.twig # find the template path
# proposal 2 (with refactor) much better to me.
$ b/c debug:twig @Twig/Exception/error.html.twig # find the template path
$ b/c debug:twig --filter=escape # filter the general infoDo you prefer this? |
cbb48c5 to
628e66c
Compare
628e66c to
2216514
Compare
|
@nicolas-grekas I added a second commit with your suggestion and MINOR FEATURE:
|
26b9e60 to
642313c
Compare
|
Fixing AppVeyor failure... Status: Needs Work |
2fb0110 to
7c26264
Compare
|
(Travis failures unrelated) Status: Needs Review |
fabpot
requested changes
Aug 28, 2018
|
Status: Needs Review |
fabpot
approved these changes
Sep 5, 2018
…o find their paths
c3a9eb1 to
7ef3d39
Compare
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Sep 5, 2018
…wig command to find their paths (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #27981). Discussion ---------- [TwigBridge] Added template "name" argument to debug:twig command to find their paths | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27911 | License | MIT | Doc PR | symfony/symfony-docs#10232 Find the template file (to load by Twig) from a given template name (useful to know which file will be loaded exactly and which ones don't):  This will also show the overridden files if they exist and the paths corresponding to their namespace. In addition, the command suggests alternatives if you made a typo (this way you can check your template name quickly): | namespace typo | template name typo | | --- | --- | |  |  | <details> <summary><strong>Other outputs</strong></summary> Discovering more alternatives:  Unknown template name:  </details> ## Update The feature was introduced into `debug:twig` command and the `filter` argument was converted to `--filter` option. The `name` argument is now the first one of the command. Commits ------- 7ef3d39 [TwigBridge] Added template \"name\" argument to debug:twig command to find their paths
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 6, 2018
This PR was merged into the master branch. Discussion ---------- Documenting debug:twig command See symfony/symfony#27981 Commits ------- 1026020 Documenting debug:twig command
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Find the template file (to load by Twig) from a given template name (useful to know which file will be loaded exactly and which ones don't):
This will also show the overridden files if they exist and the paths corresponding to their namespace.
In addition, the command suggests alternatives if you made a typo (this way you can check your template name quickly):
Other outputs
Discovering more alternatives:
Unknown template name:
Update
The feature was introduced into
debug:twigcommand and thefilterargument was converted to--filteroption. Thenameargument is now the first one of the command.