Form theme that removed custom bootstrap css class from input type file #27996
Conversation
| @@ -129,8 +129,12 @@ | |||
| {% endblock %} | |||
|
|
|||
| {% block form_widget_simple -%} | |||
| {% if use_bootstrap_custom is not defined %} | |||
There was a problem hiding this comment.
what about naming this: use_custom_file_input instead?
|
I don't like this proposal much. We already have two themes for Bootstrap ... now we're proposing to add (and maintain forever) a third one. Also, this would open the door to new themes that tweak/change other elements of the theme. I think we should be as strict as for the SymfonyStyle for the Symfony Console. It's an opinionated theme that can't be customized in any way. We (the community) can change it ... but the user can't configure it: either it uses it unchanged ... or they create their own theme. I'd like to do the same here. @lsv in spite of my previous comment, I thank you for proposing this contribution and working on this! |
|
@javiereguiluz I do see your point, and the best way is actually just to remove the custom.sass from bootstrap, which I normally do with encore, but not possible by using bootstrap cdn |
This will create a new bootstrap theme that removes the custom css class from
<input type="file">so the user can now see what files that are selected in the input.I have decided to keep the custom radio/checkbox, as these dont break the functionality.
Before
After
Usage
This a follow up to #27478