[FrameworkBundle][Workflow] fix guard expressions #28018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $this->transition = $transition; | ||
| $this->expression = $expression; | ||
| } | ||
| } |
There was a problem hiding this comment.
missing EOL. Also please remove all docblocks in this class: they don't provide anything on top of the existing type declaration, and our policy is to not add them in this situation.
|
After applying cs changes proposed by fabbot.io there are some conflicts with master branch. Should i merge them? |
|
please rebase instead of merging yes |
…ition in configuration
…pass them by reference to guard expressions
a7fe7ea to
720f943
Compare
|
@lyrixx Can you review this one? Thank you. |
|
friendly ping @lyrixx |
|
Hello. Sorry for the very late reply. I will have a look tomorrow or after tomorrow. Thanks |
|
Thanks a lot @destillat. I finished you work in #29137 and I rebased against 3.4. |
lyrixx
added a commit
that referenced
this pull request
Nov 13, 2018
…ansitions (destillat, lyrixx) This PR was merged into the 3.4 branch. Discussion ---------- [Workflow][FrameworkBundle] fixed guard event names for transitions | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28018 #28007 (comment) | License | MIT | Doc PR | There is a bug when many transitions are defined with the same name. I finished destillat's work and rebase against 3.4 as it's a bug fix. There another point of failure, but it could not be fixed on 3.4. I will be a need feature. The issue is related to `Workflow::can($subject, $transitionName)`. Since the transitionName could be not unique, we will need to support passing an instance of Transition. A new PR is incomming Commits ------- 83dc473 [FrameworkBundle] fixed guard event names for transitions fb88bfc [FrameworkBundle] fixed guard event names for transitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #28007 (comment)