Skip to content

Remove the Expires header when calling Response::expire() #28032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Remove the Expires header when calling Response::expire() #28032

wants to merge 2 commits into from

Conversation

javiereguiluz
Copy link
Member

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13341
License MIT
Doc PR -

If you agree with the #13341 proposal, this is a possible implementation.

@javiereguiluz javiereguiluz added this to the next milestone Jul 23, 2018
@javiereguiluz javiereguiluz changed the title emove the Expires header when calling Response::expire() Remove the Expires header when calling Response::expire() Jul 23, 2018
@nicolas-grekas
Copy link
Member

New feature really?

@fabpot
Copy link
Member

fabpot commented Jul 25, 2018

Looks like a bug fix to me

@javiereguiluz
Copy link
Member Author

I had some problems rebasing this as bugfix in 2.8 ... so I created #28083 to replace this.

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Feature HttpFoundation Status: Reviewed
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@javiereguiluz @nicolas-grekas @fabpot @lyrixx @carsonbot