[Form] Add help texts for checkboxes in horizontal bootstrap 4 forms #28113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks to @nicolas-grekas & @vudaltsov for making testing easier here ❤️ (#28036) |
nicolas-grekas
approved these changes
Aug 3, 2018
vudaltsov
approved these changes
Aug 3, 2018
xabbuh
approved these changes
Aug 14, 2018
|
Thank you @apfelbox. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 14, 2018
…ap 4 forms (apfelbox) This PR was merged into the 4.1 branch. Discussion ---------- [Form] Add help texts for checkboxes in horizontal bootstrap 4 forms | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | — | License | MIT | Doc PR | — Bootstrap 4 horizontal forms override the `{% block checkbox_form %}` but didn't include the help text. Regular (vertical) Bootstrap 4 are not affected, as they use the default `form_row`, which includes the `form_help()` call. ### Before  ### After  Commits ------- 1483c87 Add help texts for checkboxes in horizontal bootstrap 4 forms
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bootstrap 4 horizontal forms override the
{% block checkbox_form %}but didn't include the help text. Regular (vertical) Bootstrap 4 are not affected, as they use the defaultform_row, which includes theform_help()call.Before
After