[Form] Remove extra .form-group wrapper around file widget in bootstrap 4 #28115
Conversation
|
I based this on |
|
You should rebase it, so that it can be merged into 4.1 – as bugfix. 👍 |
|
@apfelbox rebase done, thank you. Should this PR target |
|
rebased on 4.1, PR target changed to 4.1 and description updated |
|
Not sure why appveyor build fails, this seems unrelated (it's in the SecurityBundle, which this PR doesn't change) : |
|
Is this legit at the semantic level? Could this be a BC break? Can't we get rid of the whitespace by removing the blank characters between tags? |
|
@nicolas-grekas see my comments in #28116 that should explain why this is a bugfix (I sent the same changes in a PR just minutes after this one). |
|
Thank you @MrMitch. |
… in bootstrap 4 (MrMitch) This PR was merged into the 4.1 branch. Discussion ---------- [Form] Remove extra .form-group wrapper around file widget in bootstrap 4 | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a This is a follow-up to #27958 and #27919 by @apfelbox . It fixes an extra space between the help text of a FileType widget and the widget itself. The extra space was caused by a `.form-group` wrapper in the `file_widget` block. Commits ------- 01e7fe4 [Form] Remove extra .form-group wrapper around file widget in bootstrap 4
This is a follow-up to #27958 and #27919 by @apfelbox .
It fixes an extra space between the help text of a FileType widget and the widget itself. The extra space was caused by a
.form-groupwrapper in thefile_widgetblock.