[Routing] Fixed scheme redirecting for root path #28120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cad3b36 to
2d7fdff
Compare
nicolas-grekas
approved these changes
Aug 3, 2018
xabbuh
approved these changes
Aug 6, 2018
|
Thank you @twoleds. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Routing] Fixed scheme redirecting for root path | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I and my friend found a bug with routing / matching and redirecting from http to https by forcing routes (https://symfony.com/doc/current/routing/scheme.html). It works good for all routes except the homepage (root path /). The problem is probably here (https://github.com/symfony/routing/blob/6912cfebc0ea4e7a46fdd15c9bd1f427dd39ff1b/Matcher/Dumper/PhpMatcherDumper.php#L196-L199). Symfony tries to display the welcome page instead of redirecting to https. Commits ------- 2d7fdff [Routing] Fixed scheme redirecting for root path
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I and my friend found a bug with routing / matching and redirecting from http to https by forcing routes (https://symfony.com/doc/current/routing/scheme.html). It works good for all routes except the homepage (root path /). The problem is probably here (https://github.com/symfony/routing/blob/6912cfebc0ea4e7a46fdd15c9bd1f427dd39ff1b/Matcher/Dumper/PhpMatcherDumper.php#L196-L199). Symfony tries to display the welcome page instead of redirecting to https.