Skip to content

[DI] Fix autowire inner service #28159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

hason
Copy link
Contributor

@hason hason commented Aug 8, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25631
License MIT
Doc PR -

This PR fix multiple levels of decoration. Unfortunately, this good question in origin PR has not been heard 🎧 😄. @dunglas @chalasr

@nicolas-grekas
Copy link
Member

Thank you @hason.

@nicolas-grekas nicolas-grekas merged commit b79d097 into symfony:4.1 Aug 8, 2018
nicolas-grekas added a commit that referenced this pull request Aug 8, 2018
This PR was merged into the 4.1 branch.

Discussion
----------

[DI] Fix autowire inner service

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25631
| License       | MIT
| Doc PR        | -

This PR fix multiple levels of decoration. Unfortunately, this [good question](#25631 (comment)) in origin PR has not been heard 🎧 😄. @dunglas @chalasr

Commits
-------

b79d097 [DI] Fix autowire inner service
@hason hason deleted the dec_atw branch August 8, 2018 11:55
@fabpot fabpot mentioned this pull request Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants