[DI] [FrameworkBundle] Add LoggerAwareInterface to auto configuration #28176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ CHANGELOG | |||
| * Allowed configuring PDO-based cache pools via a new `cache.adapter.pdo` abstract service | |||
| * Deprecated auto-injection of the container in AbstractController instances, register them as service subscribers instead | |||
| * Deprecated processing of services tagged `security.expression_language_provider` in favor of a new `AddExpressionLanguageProvidersPass` in SecurityBundle. | |||
| * Added auto-configured method call for `LoggerAwareinterface` instances. | |||
There was a problem hiding this comment.
Enabled autoconfiguration for LoggerAwareInterface?
chalasr
approved these changes
Aug 10, 2018
| @@ -8,6 +8,7 @@ CHANGELOG | |||
| * Allowed configuring PDO-based cache pools via a new `cache.adapter.pdo` abstract service | |||
| * Deprecated auto-injection of the container in AbstractController instances, register them as service subscribers instead | |||
| * Deprecated processing of services tagged `security.expression_language_provider` in favor of a new `AddExpressionLanguageProvidersPass` in SecurityBundle. | |||
| * Enabled autoconfiguration for `LoggerAwareInterface` | |||
There was a problem hiding this comment.
actually, I'd suggest to use Psr\Log\LoggerAwareInterface explicitly here
vudaltsov
approved these changes
Aug 11, 2018
2d08147 to
afda3c8
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 14, 2018
…o configuration (GaryPEGEOT) This PR was squashed before being merged into the 4.2-dev branch (closes #28176). Discussion ---------- [DI] [FrameworkBundle] Add LoggerAwareInterface to auto configuration | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Add the method call `setLogger` for every service implementing `Psr\Log\LoggerAwareInterface` Commits ------- afda3c8 [DI] [FrameworkBundle] Add LoggerAwareInterface to auto configuration
|
Docs issue: symfony/symfony-docs#10188 Let's please be careful to at least require a docs issue for new features :) |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the method call
setLoggerfor every service implementingPsr\Log\LoggerAwareInterface