[FrameworkBundle] message_bus alias public
#28216
Conversation
|
ControllerTrait deals with a service locator, services provided by a service locator do not need to be public (and should not). |
|
hmm, ControllerTrait is used by the FrameworkBundle's |
|
It's time to deprecate |
|
In the meantime... this is still a bug to fix 🙃 |
| @@ -1488,7 +1488,7 @@ private function registerMessengerConfiguration(array $config, ContainerBuilder | |||
| $container->register($busId, MessageBus::class)->addArgument(array())->addTag('messenger.bus'); | |||
|
|
|||
| if ($busId === $config['default_bus']) { | |||
| $container->setAlias('message_bus', $busId); | |||
| $container->setAlias('message_bus', $busId)->setPublic(true); | |||
There was a problem hiding this comment.
or $container->setAlias('message_bus', new Alias($busId, true));
There was a problem hiding this comment.
Yep. using setPublic is more explicit to me :)
|
What would be the consequence of removing |
|
ControllerTrait is internal. The consequence would be to ask people to use AbstractController instead. |
|
Thank you @sroze. |
This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] `message_bus` alias public | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28215 | License | MIT | Doc PR | ø Because it is used in the `ControllerTrait` with `get('message_bus')`... same than for `security.csrf.token_manager` and cie, it should be public. Commits ------- 51b6e9e Make the `message_bus` alias public
|
Oh okay I better use |
|
Yep. I'll send a PR to deprecate it :)
…On Tue, Aug 21, 2018 at 11:14 AM Mathieu ***@***.***> wrote:
Oh okay I better use AbstractController right now then?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28216 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxHEXgVazULdjG3QsEcAyV1ntUeGhEiks5uS8-NgaJpZM4WBdQE>
.
|
Because it is used in the
ControllerTraitwithget('message_bus')... same than forsecurity.csrf.token_managerand cie, it should be public.