[PropertyAccess] fix type error handling when writing values #28220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Aug 17, 2018
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
chalasr
approved these changes
Aug 21, 2018
nicolas-grekas
approved these changes
Aug 24, 2018
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 24, 2018
…es (xabbuh) This PR was merged into the 2.8 branch. Discussion ---------- [PropertyAccess] fix type error handling when writing values | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 4575451 fix type error handling when writing values
xabbuh
added a commit
to opensoftwareconsulting/rich-model-forms-bundle
that referenced
this pull request
Aug 24, 2018
After symfony/symfony#28220 had been merged type errors were caught as expected by the PropertyAccess component. This means that they were transformed into InvalidArgumentException instances and were never passed as type errors to the ArgumentTypeMismatchExceptionHandler.
xabbuh
added a commit
to opensoftwareconsulting/rich-model-forms-bundle
that referenced
this pull request
Aug 24, 2018
After symfony/symfony#28220 had been merged type errors were caught as expected by the PropertyAccess component. This means that they were transformed into InvalidArgumentException instances and were never passed as type errors to the ArgumentTypeMismatchExceptionHandler.
This was referenced Aug 27, 2018
Merged
Merged
Merged
xabbuh
added a commit
to opensoftwareconsulting/rich-model-forms-bundle
that referenced
this pull request
Aug 30, 2018
This PR was merged into the 0.1-dev branch. Discussion ---------- fix failing tests After symfony/symfony#28220 had been merged type errors were caught as expected by the PropertyAccess component. This means that they were transformed into InvalidArgumentException instances and were never passed as type errors to the ArgumentTypeMismatchExceptionHandler. Commits ------- d258087 fix failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.