[Serializer] AbstractObjectNormalizer improve performance #28277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
969ff54 to
3dcc828
Compare
sroze
reviewed
Aug 26, 2018
| } | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| return $this->typesCache[$key] = null; |
There was a problem hiding this comment.
isset($this->typesCache[$key]) will be false anyway if the value is null.
There was a problem hiding this comment.
You're right. Now marked as false and added extra check at the start to avoid using array_key_exists()
aca08e4 to
626d93d
Compare
626d93d to
4224145
Compare
sroze
approved these changes
Aug 27, 2018
fabpot
approved these changes
Aug 27, 2018
|
Thank you @martiis. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2018
…nce (martiis) This PR was merged into the 4.2-dev branch. Discussion ---------- [Serializer] AbstractObjectNormalizer improve performance | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28276 | License | MIT Check ticket for description Commits ------- 4224145 [Serializer] AbstractObjectNormalizer improve perf when checking types
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check ticket for description