Skip to content

[PhpUnitBridge] keep compat with composer 1.0 #28284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Remove --no-suggest when installing PHPUnit from the bridge to keep compat with composer 1.0, which is shipped with Ubuntu 16.04LTS.

@kevinjhappy
Copy link
Contributor

Apparently with the option --no-dev, the option --no-suggest is skipped
composer/composer#2066
So the change is great 👍

@fabpot
Copy link
Member

fabpot commented Aug 27, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 28492a7 into symfony:3.4 Aug 27, 2018
fabpot added a commit that referenced this pull request Aug 27, 2018
…kas)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] keep compat with composer 1.0

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Remove `--no-suggest` when installing PHPUnit from the bridge to keep compat with composer 1.0, which is shipped with Ubuntu 16.04LTS.

Commits
-------

28492a7 [PhpUnitBridge] keep compat with composer 1.0
This was referenced Aug 28, 2018
@nicolas-grekas nicolas-grekas deleted the phpunit-no-suggest branch August 30, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants