-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Finder] Apply PathFilterIterator only to directory root if path provided as non-regex #28410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Apply PathFilterIterator only to directory root if path provided as non regex
We never merge BC breaks sorry. Is there any other way around that wouldn't involve a BC break? |
Hmm... I can suggest implementing |
Continuing the discussion here by hope of merging this :) (see #28158 (comment)) Is it really considered a break if the behavior it's fixing is broken? By "broken" I mean it's not respecting the original contract which is:
(https://api.symfony.com/4.1/Symfony/Component/Finder/Finder.html#method_exclude) This issue is becoming problematic in Bref (brefphp/bref#51) so I'm really hoping we can find a solution :) |
Agree this would be very nice to have. |
@erickskrauch do you want to do it or do you want me to help you ? |
@Simperfit you mean update my PR and resolve conflicts? |
@Simperfit not sure I understand, is this a green light to merge this once conflicts are fixed? Edit: sorry my bad, i mixed up "Contributor" and "Member". I guess this PR is still blocked per the discussion above. |
I'm closing because this breaks BC and this staled. |
@nicolas-grekas, I'm still in touch if it is a condition of removing the "stale" label :) |
Great thanks. Let's keep this PR closed and try a new one that doesn't break BC. Note that I'd prefer not adding a |
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
Fixes symfony#28158 Fixes symfony#47431 Related: symfony#26396 Related: symfony#9158 Related: symfony#28410
#28158