[Ldap] Add verbose ext-ldap error if present for easier debugging #28424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba2d6f0 to
0845126
Compare
nicolas-grekas
approved these changes
Sep 10, 2018
| @@ -89,7 +89,12 @@ public function execute() | |||
| } | |||
|
|
|||
| if (false === $this->search) { | |||
| throw new LdapException(sprintf('Could not complete search with dn "%s", query "%s" and filters "%s".', $this->dn, $this->query, implode(',', $this->options['filter']))); | |||
| $ldapError = ''; | |||
| if (0 !== ($errno = ldap_errno($con))) { | |||
There was a problem hiding this comment.
I'd suggest to write this as if ($errno = ldap_errno($con)) {
There was a problem hiding this comment.
I hoped to find something like LDAP_ERROR_NONE for better readability, but failed. Initial idea was
if (LDAP_ERROR_NONE !== ($errno = ldap_errno($con))) {
Without that your suggestion looks better, indeed, I'll fix it
|
(to be merged on master actually as that's not a bug fix but an improvement.) |
0845126 to
fb861a6
Compare
|
@nicolas-grekas should I rebase? |
|
@scaytrase if you can please yes, otherwise no worries we'll take care of it. |
fb861a6 to
761415f
Compare
|
rebased |
|
Thank you @scaytrase. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 21, 2018
…r debugging (scaytrase) This PR was merged into the 4.2-dev branch. Discussion ---------- [Ldap] Add verbose ext-ldap error if present for easier debugging | Q | A | ------------- | --- | Branch? | master (be careful when merging) | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | | Fixed tickets | #28149 | License | MIT | Doc PR | Added an optional message suffix if ldap_errno is not equals to 0 Commits ------- 761415f Add verbose ext-ldap error if present for easier debugging
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an optional message suffix if ldap_errno is not equals to 0