[Form][TwigBridge] fix not displaying labels when value is false #28469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 14, 2018
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28198 |
| License | MIT |
| Doc PR |
xabbuh
commented
Sep 15, 2018
| @@ -133,6 +133,11 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| 'invalid_message_parameters', | |||
| ))); | |||
|
|
|||
| if (false === $options['label']) { | |||
There was a problem hiding this comment.
This change technically could go into the 2.8 branch too. Though it would only fix custom form themes there. Our built-in form themes do not suffer from this issue in older branches.
HeahDude
approved these changes
Sep 15, 2018
nicolas-grekas
approved these changes
Sep 17, 2018
|
Thank you @xabbuh. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 18, 2018
… false (xabbuh) This PR was merged into the 4.1 branch. Discussion ---------- [Form][TwigBridge] fix not displaying labels when value is false | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28198 | License | MIT | Doc PR | Commits ------- c4a6c9f fix not displaying labels when value is false
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Sep 19, 2018
This change does not fix any built-in Symfony form themes, but takes into account the changes made in symfony#28469 to allow third-party form themes work properly.
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Form] forward false label option to nested types | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28469 (comment) | License | MIT | Doc PR | This change does not fix any built-in Symfony form themes, but takes into account the changes made in #28469 to allow third-party form themes work properly. Commits ------- 3247cde forward false label option to nested types
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Sep 20, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [Form] forward false label option to nested types | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#28469 (comment) | License | MIT | Doc PR | This change does not fix any built-in Symfony form themes, but takes into account the changes made in #28469 to allow third-party form themes work properly. Commits ------- 3247cdeea9 forward false label option to nested types
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.