[MonologBridge] Re-add option option to ignore empty context and extra data #28471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New feature, isn't it? |
|
@nicolas-grekas No, I’d say it restores a feature that was there before and accidentally got lost - see description. |
nicolas-grekas
approved these changes
Sep 18, 2018
chalasr
approved these changes
Sep 18, 2018
7565681 to
d1e7438
Compare
|
Thank you @mpdude. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2018
…xt and extra data (mpdude) This PR was squashed before being merged into the 3.4 branch (closes #28471). Discussion ---------- [MonologBridge] Re-add option option to ignore empty context and extra data | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | In #11496, an option was added to `ConsoleFormatter` to ignore empty context and extra data. This setting was even turned on by default. The `ConsoleHandler` was then overhauled in #21705. During this change, the option got lost. Commits ------- d1e7438 [MonologBridge] Re-add option option to ignore empty context and extra data
|
(would you mind checking where this would need to be mentioned in the doc please?) |
|
@nicolas-grekas you mean the changelog or rather the symfony-docs? |
|
The Symfony doc if possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #11496, an option was added to
ConsoleFormatterto ignore empty context and extra data. This setting was even turned on by default.The
ConsoleHandlerwas then overhauled in #21705. During this change, the option got lost.