[DI] Detect circular references with ChildDefinition parent #28480
Conversation
|
Oups, didn't see that someone already worked on it: #28452 |
|
Just pushed a test case since it looks to be the good way to fix this issue regarding comments on the other pull request. I pushed on master because it is a very similar issue as the previous one I fixed (#28315) which was merged on master. |
| @@ -396,4 +396,20 @@ protected function process(ContainerBuilder $container) | |||
| $pass = new ResolveChildDefinitionsPass(); | |||
| $pass->process($container); | |||
| } | |||
|
|
|||
| /** | |||
| * @expectedException \Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException | |||
There was a problem hiding this comment.
could be worth adding an @expectedExceptionMessage: right now, I get: Service "a": Service "a": Service "a": Service "a": Circular reference detected for service "c", path: "c -> b -> a -> c"., which might need some tweaks :)
There was a problem hiding this comment.
hmm, that's resolveDefinition prefixing the exception message. And the multiple prefixing looks really weird though.
There was a problem hiding this comment.
Oups, didn't see that. I just pushed a fix.
There was a problem hiding this comment.
still worth adding @expectedExceptionMessage :)
There was a problem hiding this comment.
Maybe @expectedExceptionMessageRegExp to test if exception message is not prefixed?
|
(for 3.4!) |
|
Thank you @Seb33300. |
…t (Seb33300) This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #28480). Discussion ---------- [DI] Detect circular references with ChildDefinition parent | Q | A | ------------- | --- | Branch? | 3.4 (be careful when merging) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28312 | License | MIT | Doc PR | I will provide a test case if the fix looks good for you :) Commits ------- 2a59c8e [DI] Detect circular references with ChildDefinition parent
I will provide a test case if the fix looks good for you :)