[Translation] Added support for multiple files or directories in XliffLintCommand #28522
Conversation
6c9dacb to
d329ebe
Compare
| @@ -71,7 +71,7 @@ | |||
| "symfony/property-info": "<3.4", | |||
| "symfony/serializer": "<4.1", | |||
| "symfony/stopwatch": "<3.4", | |||
| "symfony/translation": "<4.2", | |||
| "symfony/translation": "<=4.2", | |||
There was a problem hiding this comment.
This doesn't look right to me as it would actually mean that when 4.2 is released we wouldn't be able to use FrameworkBundle with any stable release of the Translation component then.
There was a problem hiding this comment.
We can just revert all the changes for this file (it's okay if the deps=high build fails in this case).
There was a problem hiding this comment.
it's okay if the deps=high build fails in this case
Actually no, it's not OK on master: a deps=high failure on master means 4.1 will break with the change when using 4.2 deps.
But yes! the composer.json changes must be reverted.
There was a problem hiding this comment.
Reverted, but deps=high will fails, not sure how to solve it :( I tried how far I could, so I need help here.
- Installing symfony/translation (4.2.x-dev): Downloading (100%)
There was a problem hiding this comment.
Proposal to patch 4.1 in #28525
src/Symfony/Bundle/FrameworkBundle/Tests/Command/XliffLintCommandTest.php
Outdated
Show resolved
Hide resolved
d329ebe to
64df255
Compare
d0d4184 to
88ec37b
Compare
|
Thank you @yceruto. |
…ctories in XliffLintCommand (yceruto) This PR was squashed before being merged into the 4.2-dev branch (closes #28522). Discussion ---------- [Translation] Added support for multiple files or directories in XliffLintCommand | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#10368 Same approach of #28521 Commits ------- 88ec37b [Translation] Added support for multiple files or directories in XliffLintCommand
…ories in XliffLintCommand (yceruto, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [Translation] Added support for multiple files or directories in XliffLintCommand See symfony/symfony#28522 Commits ------- e4494bd Added the versionadded directive e68d242 typo 5657303 Added support for multiple files or directories
Same approach of #28521