-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Process] fix locking of pipe files on Windows #28689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nicolas-grekas
commented
Oct 2, 2018
Q | A |
---|---|
Branch? | 2.8 |
Bug fix? | yes |
New feature? | no |
BC breaks? | no |
Deprecations? | no |
Tests pass? | yes |
Fixed tickets | #28655 |
License | MIT |
Doc PR | - |
bc5a086
to
8025e98
Compare
@SailorMax patch updated, can you try the new one please? |
With new patch all my processes has exitCode = 1 and did not work at all. Can't write stdout and stderr to locked files? |
5848edd
to
34cc895
Compare
34cc895
to
d64bd3b
Compare
Thanks, can you try again please? It should be good now (at least appveyor is green.) |
Yes, latest patch work as expected in my case. |
But after work temp files remain in the temp-directory. Is it feature? :) |
It is :) Actually there is no way around: unlinking the file would create race conditions. |
For me - not a problem :) |
Thank you @nicolas-grekas. |
…ekas) This PR was merged into the 2.8 branch. Discussion ---------- [Process] fix locking of pipe files on Windows | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28655 | License | MIT | Doc PR | - Commits ------- d64bd3b [Process] fix locking of pipe files on Windows