[WIP][FrameworkBundle] Add debug autoconfigure command #28730
Conversation
| } | ||
| $tableRows[] = array('Public', $autoconfiguredInstanceofItem->isPublic() ? 'yes' : 'no'); | ||
| $tableRows[] = array('Shared', $autoconfiguredInstanceofItem->isShared() ? 'yes' : 'no'); | ||
| $tableRows[] = array('Autowired', $autoconfiguredInstanceofItem->isAutowired() ? 'yes' : 'no'); |
There was a problem hiding this comment.
The only things that can be set by autoconfiguration are tags, method calls and bindings.
There is no need to list anything else.
There was a problem hiding this comment.
I removed Public, Shared and Autowired and I add bindings
| } | ||
|
|
||
| if ($tags && array_values($tags) !== array(array(array()))) { | ||
| $tableRows[] = array('Tags attributes', $this->dumpTagsAttributes($tags)); |
There was a problem hiding this comment.
If there are any attributes, they should be listed next to their corresponding tags.
There was a problem hiding this comment.
If there are many attributes, the command displays like that
--------------- --------------------------
Option Value
--------------- --------------------------
Tag kernel.reset
Tag attribute [
[
"method" => "reset"
]
]
Tag kernel.reset2
Tag attribute [
[
"method" => "reset2"
]
]
--------------- --------------------------
| /** @var ChildDefinition $autoconfiguredInstanceofItem */ | ||
| foreach ($autoconfiguredInstanceofItems as $key => $autoconfiguredInstanceofItem) { | ||
| $tags = $autoconfiguredInstanceofItem->getTags(); | ||
| $tableRows = array(); |
There was a problem hiding this comment.
maybe we can get rid of the $tableRows array by using addRow() and render(), as this is for master. IMO its more readable afterwards
docs: https://symfony.com/doc/current/components/console/helpers/table.html#modifying-rendered-tables
There was a problem hiding this comment.
I'm not sure it's more readable. To have the same style that the others commands, it is necessary to configure the table.
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php
index bffdd32751..6d80649634 100644
--- a/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php
+++ b/src/Symfony/Bundle/FrameworkBundle/Command/DebugAutoconfigurationCommand.php
@@ -12,6 +12,7 @@
namespace Symfony\Bundle\FrameworkBundle\Command;
use Symfony\Component\Console\Command\Command;
+use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
Stash this hunk [y,n,q,a,d,j,J,g,/,e,?]? y
@@ -91,26 +92,30 @@ EOF
/** @var ChildDefinition $autoconfiguredInstanceofItem */
foreach ($autoconfiguredInstanceofItems as $key => $autoconfiguredInstanceofItem) {
- $tableRows = array();
+ $section = $output->section();
+ $table = new Table($section);
+ $table->setStyle(Table::getStyleDefinition('symfony-style-guide'));
+ $table->addRow(array('Option', 'Value'));
foreach ($autoconfiguredInstanceofItem->getTags() as $tag => $tagAttributes) {
- $tableRows[] = array('Tag', $tag);
+ $table->addRow(array('Tag', $tag));
if ($tagAttributes !== array(array())) {
- $tableRows[] = array('Tag attribute', $this->dumpTagAttribute($tagAttributes));
+ $table->addRow(array('Tag attribute', $this->dumpTagAttribute($tagAttributes)));
}
}
if ($autoconfiguredInstanceofItem->getMethodCalls()) {
- $tableRows[] = array('Method call', $this->dumpMethodCall($autoconfiguredInstanceofItem));
+ $table->addRow(array('Method call', $this->dumpMethodCall($autoconfiguredInstanceofItem)));
}
if ($autoconfiguredInstanceofItem->getBindings()) {
- $tableRows[] = array('Bindings', $this->dumpBindings($autoconfiguredInstanceofItem));
+ $table->addRow(array('Bindings', $this->dumpBindings($autoconfiguredInstanceofItem)));
}
$io->writeln(sprintf("Autoconfiguration for \"%s\"\n==============================================", $key));
$io->newLine();
- $io->table(array('Option', 'Value'), $tableRows);
+ $table->render();
+ $io->newLine();
}
}
|
Could you please post a screenshot of the output? EDIT: Please add it to the PR header |
35a8f47 to
09ea820
Compare
|
@OskarStark Have you seen the output of command in the PR header, it requires to unfold. Do you prefer a screenshot ? |
| @@ -0,0 +1,9 @@ | |||
| <?php | |||
|
|
|||
| namespace Symfony\Bundle\FrameworkBundle\Tests\Functional\Bundle\DebugAutoconfigurationBundle; | |||
There was a problem hiding this comment.
Maybe, I can use the TestBundle instead of create a new bundle ?
4074a0d to
00fb8ae
Compare
|
Ah i missed it 😊 |
There was a problem hiding this comment.
not sure we need a new command, feels like it should be part of debug:container --autoconfiguration instead. Re-building and YAML dumping the container here looks suspicious to me.
Alternatively extend from ContainerDebugCommand like DebugAutowiringCommand also does.
Ok, I don't like it too but I didn't see other way to display method calls and bindings. |
Close #26295
Replace the pull request #26745.
Creation of a new command as proposed in the comment #26745 (comment) to show the full template of the autoconfigure of interfaces/classes
Output of the command based on modified symfony-demo application to have binding autoconfiguration, multiple tags attributes and multiple method calls