Add a messenger middleware to enforce null results #28758
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sroze
suggested changes
Oct 7, 2018
| { | ||
| $result = $next($message); | ||
| if (null !== $result) { | ||
| throw new NonNullResultException(sprintf('Non null result for message %s.', \get_class($message))); |
There was a problem hiding this comment.
- Non null result for message %s.
+ Non null result for message "%s": at least one handler returned something but this is prohibited by this middleware.|
Thanks for the suggestion ! Doc: symfony/symfony-docs#10442 |
azjezz
approved these changes
Oct 7, 2018
|
@sroze do you like the proposed name? |
|
@javiereguiluz : For myself, I find |
|
This will stay the case, as the messenger bus now returns |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little middleware to make sure a message bus doesn't return any result.