[DI] fix dumping inline services again #28760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 8, 2018
stof
reviewed
Oct 9, 2018
|
|
||
| $b->foo = $instance; | ||
|
|
||
| $a->bar = $b; |
There was a problem hiding this comment.
shouldn't we set this property earlier, to have the property set at the time of new \App\Foo($a) ?
There was a problem hiding this comment.
It's important to set deps as late as possible, so that the consumer see them as populated as possible. The reason is that code usually expect it this way. The typical exemple is doctrine's configuration object, which must be fully defined before injection, so that consumers can use it immediately.
nicolas-grekas
added a commit
that referenced
this pull request
Oct 10, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [DI] fix dumping inline services again | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28720 #28710 | License | MIT | Doc PR | - The main fix is in `PhpDumper::addInlineService()` Fixes a few other glitches found meanwhile. Commits ------- a854b0a [DI] fix dumping inline services again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main fix is in
PhpDumper::addInlineService()Fixes a few other glitches found meanwhile.