[SecurityBundle] do not override custom access decision configs #28793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 9, 2018
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28766 |
| License | MIT |
| Doc PR |
chalasr
approved these changes
Oct 9, 2018
ogizanagi
approved these changes
Oct 10, 2018
javiereguiluz
approved these changes
Oct 10, 2018
fabpot
requested changes
Oct 10, 2018
| ); | ||
| if (!isset($v['access_decision_manager'])) { | ||
| $v['access_decision_manager'] = array(); | ||
| } |
There was a problem hiding this comment.
This part is not needed as PHP won't emit a notice when a directory is not defined and will happily create it on demand (line below).
fabpot
approved these changes
Oct 10, 2018
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
…nfigs (xabbuh) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] do not override custom access decision configs | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28766 | License | MIT | Doc PR | Commits ------- 7743146 do not override custom access decision configs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.