[Routing] simplify PhpMatcherDumper by splitting code logic from route data #28798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08c8104 to
22186c7
Compare
|
(fabbot fixed) |
fabpot
approved these changes
Oct 10, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
…gic from route data (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Routing] simplify PhpMatcherDumper by splitting code logic from route data | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR splits all logic that is currently dumped into the matcher in a dedicated trait. This makes the code easier to maintain and prepares for the next step (making the dumper compile routes as a set of PHP arrays instead of code.) This diff is huge because affected fixtures are also huge, but it's negative, removing 1200 lines! Commits ------- 22186c7 [Routing] simplify PhpMatcherDumper by splitting code logic from route data
stof
reviewed
Oct 10, 2018
| @@ -56,13 +55,11 @@ public function dump(array $options = array()) | |||
|
|
|||
| // trailing slash support is only enabled if we know how to redirect the user | |||
| $interfaces = class_implements($options['base_class']); | |||
| $supportsRedirections = isset($interfaces[RedirectableUrlMatcherInterface::class]); | |||
There was a problem hiding this comment.
what about this distinction between supporting it or no ? Is it gone ?
There was a problem hiding this comment.
Yes it's gone, it fits no purpose.
There was a problem hiding this comment.
Oups, totally unrelated answer I had something else in mind :)
So no, it's not gone, it's here:
https://github.com/symfony/symfony/pull/28798/files#diff-b510c08a4adf31a17002f25ee499fb85R41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits all logic that is currently dumped into the matcher in a dedicated trait.
This makes the code easier to maintain and prepares for the next step (making the dumper compile routes as a set of PHP arrays instead of code.)
This diff is huge because affected fixtures are also huge, but it's negative, removing 1200 lines!