[Finder] make reverse sorting a bit more generic #28802
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 10, 2018
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27967 (comment) |
| License | MIT |
| Doc PR | - |
2cd108a to
ce861d1
Compare
fabpot
approved these changes
Oct 10, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 10, 2018
…s-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Finder] make reverse sorting a bit more generic | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27967 (comment) | License | MIT | Doc PR | - Commits ------- ce861d1 [Finder] make reverse sorting a bit more generic
stof
reviewed
Oct 10, 2018
| * | ||
| * @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
| */ | ||
| class ReverseSortingIterator implements \IteratorAggregate |
There was a problem hiding this comment.
this class should be deprecated, not removed, as it was not marked internal
There was a problem hiding this comment.
This class only exists in master (as the PR was merged a few hours ago only).
| }; | ||
| } elseif (self::SORT_BY_NONE === $sort) { | ||
| $this->sort = $order; | ||
| } elseif (\is_callable($sort)) { |
There was a problem hiding this comment.
what about order support for this case ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.