[DependencyInjection] Fix tags on multiple decorated service #28820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for working on this! Could you add a test case please? |
|
I have added a Test which fails, without the Changes. |
OskarStark
approved these changes
Oct 12, 2018
nicolas-grekas
approved these changes
Oct 14, 2018
|
FYI I pushed-forced an alternative implementation that more precisely focuses on fixing multiple decorations while taking care of not changing the semantics of decorating unrelated aliases. |
|
Looks fine for me 😊 |
|
Thank you @shyim. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 31, 2018
…ce (Soner Sayakci) This PR was merged into the 3.4 branch. Discussion ---------- [DependencyInjection] Fix tags on multiple decorated service | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28682 | License | MIT | Doc PR | After the first run in the loop with the same decorated service it goes only in the hasAlias condition. The tags will be not set here, so the `ResolveTaggedIteratorArgumentPass` will handle only the first decoration. Commits ------- 90f8df2 [DependencyInjection] Fix tags on multiple decorated service
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the first run in the loop with the same decorated service it goes only in the hasAlias condition. The tags will be not set here, so the
ResolveTaggedIteratorArgumentPasswill handle only the first decoration.