Skip to content

Allow integers as default console option value #28834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2018
Merged

Conversation

curry684
Copy link
Contributor

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT
Doc PR symfony/symfony-docs#...

B/C break fix for static analysis tools.

Ref #28374 (comment)

@fabpot
Copy link
Member

fabpot commented Oct 12, 2018

Good catch, thanks @curry684.

@fabpot fabpot merged commit 064950a into symfony:2.8 Oct 12, 2018
fabpot added a commit that referenced this pull request Oct 12, 2018
This PR was squashed before being merged into the 2.8 branch (closes #28834).

Discussion
----------

Allow integers as default console option value

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

B/C break fix for static analysis tools.

Ref #28374 (comment)

Commits
-------

064950a Allow integers as default console option value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants