Skip to content

[Process] A test case for stringifying of Process arguments #28864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2018

Conversation

vudaltsov
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets for #28863
License MIT
Doc PR

Checks that non-string arguments passed to Process constructor are typecasted to string

@nicolas-grekas
Copy link
Member

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit 0d54342 into symfony:3.4 Oct 14, 2018
nicolas-grekas added a commit that referenced this pull request Oct 14, 2018
…nts (vudaltsov)

This PR was merged into the 3.4 branch.

Discussion
----------

[Process] A test case for stringifying of Process arguments

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | for #28863
| License       | MIT
| Doc PR        |

Checks that non-string arguments passed to Process constructor are typecasted to string

Commits
-------

0d54342 Add a test case for stringifying of Process arguments
@vudaltsov vudaltsov deleted the process-argument-escape-test branch October 14, 2018 18:42
@vudaltsov
Copy link
Contributor Author

@nicolas-grekas , could you also merge this into 4.1, so that I can rebase and test #28863?

@nicolas-grekas
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants