[HttpKernel] fix deprecating KernelInterface::getRootDir() #28890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3cc1aa9 to
4181a94
Compare
4181a94 to
819f525
Compare
|
(ready) |
fabpot
requested changes
Oct 16, 2018
| @@ -38,8 +33,7 @@ class CodeHelper extends Helper | |||
| public function __construct($fileLinkFormat, string $projectDir, string $charset) | |||
| { | |||
| $this->fileLinkFormat = $fileLinkFormat ?: ini_get('xdebug.file_link_format') ?: get_cfg_var('xdebug.file_link_format'); | |||
| $this->projectDir = str_replace('\\', '/', $projectDir).'/'; | |||
| $this->rootDir = $this->projectDir; | |||
| $this->rootDir = str_replace('\\', '/', $projectDir).'/'; | |||
There was a problem hiding this comment.
I would keep the new name, it's easier to follow along.
There was a problem hiding this comment.
but changing it breaks BC...
There was a problem hiding this comment.
Yes and no. That's internal/obsolete code (templating vs Twig).
fabpot
approved these changes
Oct 16, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2018
…() (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpKernel] fix deprecating KernelInterface::getRootDir() | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Follow up of #28810. Did I get it right? Commits ------- 819f525 [HttpKernel] fix deprecating KernelInterface::getRootDir()
This was referenced Oct 24, 2018
fabpot
added a commit
that referenced
this pull request
Oct 25, 2018
…0NL) This PR was merged into the 4.2-dev branch. Discussion ---------- [TwigBridge] Remove $rootDir argument in CodeExtension | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony/symfony-docs#10547 (comment) | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Forgotten in #28890 cc @javiereguiluz Commits ------- f894724 [TwigBridge] Remove $rootDir argument in CodeExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #28810.
Did I get it right?