[Messenger] make Envelope first class citizen for middleware handlers #28914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23527d2 to
1f42392
Compare
1f42392 to
5c8f083
Compare
ogizanagi
approved these changes
Oct 18, 2018
weaverryan
approved these changes
Oct 19, 2018
fbb0d2a to
881e039
Compare
yes! same for |
881e039 to
ae46a43
Compare
|
(rebased, ready) |
sroze
approved these changes
Oct 21, 2018
|
Thank you @nicolas-grekas. |
sroze
added a commit
that referenced
this pull request
Oct 21, 2018
…leware handlers (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] make Envelope first class citizen for middleware handlers | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR sits on top of #28909 so that only the 2nd commit should be reviewed for now, until I rebase it. This idea has already been proposed and rejected in #27322. Yet, now that I've reviewed in depth the component, I politely but strongly suggest to reconsider. Middleware handlers are the central piece of the routing layer. When `dispatch()` accepts `object|Envelope`, it's because it sits on the outer boundary of the component. `handle()` on the contrary plugs inside its core routing logic, so that it's very legitimate to require them to deal with `Envelope` objects. Yes, some middleware care only about the message inside. That's fine calling `getMessage()` for them. Right now, we built a complex magic layer that acts as a band-aid *just* to save this call to `getMessage()`. For middleware that want the envelope, we require an additional interface that magically *changes* the expected argument. That's very fragile design: it breaks the `L` in `SOLID`... Looking at the diff stat, this is most natural. Commits ------- ae46a43 [Messenger] make Envelope first class citizen for middleware handlers
Koc
reviewed
Oct 21, 2018
| /** | ||
| * @internal | ||
| */ | ||
| interface NextInterface |
There was a problem hiding this comment.
In the docblock above, to document the signature of the callable.
This was referenced Oct 25, 2018
Closed
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #28909 so that only the 2nd commit should be reviewed for now, until I rebase it.
This idea has already been proposed and rejected in #27322.
Yet, now that I've reviewed in depth the component, I politely but strongly suggest to reconsider.
Middleware handlers are the central piece of the routing layer.
When
dispatch()acceptsobject|Envelope, it's because it sits on the outer boundary of the component.handle()on the contrary plugs inside its core routing logic, so that it's very legitimate to require them to deal withEnvelopeobjects. Yes, some middleware care only about the message inside. That's fine callinggetMessage()for them.Right now, we built a complex magic layer that acts as a band-aid just to save this call to
getMessage(). For middleware that want the envelope, we require an additional interface that magically changes the expected argument. That's very fragile design: it breaks theLinSOLID...Looking at the diff stat, this is most natural.