Skip to content

[BrowserKit] Remove undefined variable $str #29004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

samnela
Copy link
Contributor

@samnela samnela commented Oct 27, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets no
License MIT
Doc PR no

@chalasr chalasr added this to the 4.2 milestone Oct 28, 2018
@fabpot
Copy link
Member

fabpot commented Oct 28, 2018

Thank you @samnela.

@fabpot fabpot merged commit 4b3fdd6 into symfony:master Oct 28, 2018
fabpot added a commit that referenced this pull request Oct 28, 2018
This PR was merged into the 4.2-dev branch.

Discussion
----------

[BrowserKit] Remove undefined variable $str

| Q             | A
| ------------- | ---
| Branch?       | master  <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | no   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | no <!-- required for new features -->

<!--
Write a short README entry for your feature/bugfix here (replace this comment block.)
This will help people understand your PR and can be used as a start of the Doc PR.
Additionally:
 - Bug fixes must be submitted against the lowest branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

4b3fdd6 [BrowserKit] Remove undefined variable
@samnela samnela deleted the remove-undefined-variable branch October 29, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants