Combine consecutive issets #29008
Closed
Combine consecutive issets #29008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP-CS-Fixer rule combine_consecutive_issets
1b239ed to
d9b3815
Compare
OskarStark
approved these changes
Oct 28, 2018
|
I tried to do this last year (https://github.com/symfony/symfony/pulls?q=is%3Apr+isset+author%3Ajaviereguiluz+is%3Aclosed) but was refused. |
|
👎 for the same reasons :) |
|
Closing as explained in #22684 thanks for proposing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP-CS-Fixer rule combine_consecutive_issets