[HttpKernel] Fix BC break in Kernel name #29032
Merged
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Oct 30, 2018
|
(failures related though :)) |
|
looks like this breaks some tests |
299f1ce to
872a772
Compare
|
I should have check the tests before pushing, they should pass now. |
Taluu
reviewed
Oct 30, 2018
nicolas-grekas
approved these changes
Oct 30, 2018
Tobion
approved these changes
Oct 31, 2018
|
Good catch, thanks @jvasseur. |
Tobion
added a commit
that referenced
this pull request
Oct 31, 2018
This PR was merged into the 4.2-dev branch. Discussion ---------- [HttpKernel] Fix BC break in Kernel name | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Fix a BC break introduced by #28810 where the name of the kernel where change form the name of the folder containing the kernel class to the name of the folder containing the project. This introduced a bug with deployment processes where the cache warmup is done before moving the application to a folder with a different name and removing the possibility to compile the container (either by moving to a read-only filesystem or by removing the config directory). Commits ------- 872a772 Fix BC break in Kernel name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a BC break introduced by #28810 where the name of the kernel where change form the name of the folder containing the kernel class to the name of the folder containing the project.
This introduced a bug with deployment processes where the cache warmup is done before moving the application to a folder with a different name and removing the possibility to compile the container (either by moving to a read-only filesystem or by removing the config directory).