Skip to content

[Messenger][FrameworkBundle] Fix bus name on traceable middleware #29038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Messenger][FrameworkBundle] Fix bus name on traceable middleware #29038

wants to merge 1 commit into from

Conversation

ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Oct 31, 2018 •
edited
Loading

Q A
Branch? 4.2
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29034
License MIT
Doc PR N/A

Supersedes #29034.

bin/console debug:container query_bus.middleware.traceable --show-arguments

Information for Service "query_bus.middleware.traceable"
========================================================

 ---------------- ------------------------------------------------------------ 
  Option           Value                                                       
 ---------------- ------------------------------------------------------------ 
  Service ID       query_bus.middleware.traceable                              
  Class            Symfony\Component\Messenger\Middleware\TraceableMiddleware                                                    
  Arguments        query_bus                                                   
                   Service(debug.stopwatch)                                    
 ---------------- ------------------------------------------------------------

@ogizanagi ogizanagi added this to the 4.2 milestone Oct 31, 2018
@ogizanagi ogizanagi mentioned this pull request Oct 31, 2018
Closed
@nicolas-grekas
Copy link
Member

👎 let's kill these workarounds on top of hacks. We need to play by the rules of the definition inheritance, not against.

@sroze
Copy link
Contributor

sroze commented Oct 31, 2018

Agree with, 👎 I feel it's a bigger hack that the other alternative. 😄

@nicolas-grekas
Copy link
Member

Already fixed by #29010 (comment)
Removing code instead of adding more is a better way to fix things ;)

@sroze
Copy link
Contributor

sroze commented Oct 31, 2018

No it's not, unless you changed things since yesterday evening 🤔

@nicolas-grekas
Copy link
Member

I did, see linked comment ;)

@sroze sroze closed this Oct 31, 2018
@ogizanagi ogizanagi deleted the fix/messenger/traceable_midd_bus_name branch October 31, 2018 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug FrameworkBundle Messenger Status: Needs Review
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ogizanagi @nicolas-grekas @sroze @carsonbot