Skip to content

Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request" #29047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2018

Conversation

Tobion
Copy link
Contributor

@Tobion Tobion commented Oct 31, 2018

This reverts commit 8a127ea.

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26486
License MIT
Doc PR

As I said in #26486 (comment) and people wonder in https://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core.
I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of */* and this is what people usually need in REST APIs etc.
But for now, we should revert it before it gets released like this.

@nicolas-grekas
Copy link
Member

Thank you @Tobion.

@nicolas-grekas nicolas-grekas merged commit 397ed83 into symfony:master Nov 1, 2018
nicolas-grekas added a commit that referenced this pull request Nov 1, 2018
…ethod for Request" (Tobion)

This PR was merged into the 4.2-dev branch.

Discussion
----------

Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"

This reverts commit 8a127ea.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #26486
| License       | MIT
| Doc PR        |

As I said in #26486 (comment) and people wonder in https://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core.
I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of `*/*` and this is what people usually need in REST APIs etc.
But for now, we should revert it before it gets released like this.

Commits
-------

397ed83 Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"
@Tobion Tobion deleted the revert-getAcceptableFormats branch November 1, 2018 17:07
This was referenced Nov 3, 2018
xabbuh added a commit to symfony/symfony-docs that referenced this pull request Nov 11, 2018
…eptableFormat… (kunicmarko20)

This PR was merged into the master branch.

Discussion
----------

Revert "minor #9898 [HttpFoundation] Add info for getAcceptableFormat…

This reverts commit fbca6db, because it was reverted in the core symfony/symfony#29047.

closes #10656

Commits
-------

27967c2 Revert "minor #9898 [HttpFoundation] Add info for getAcceptableFormats() method (AndreiIgna)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants