Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request" #29047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8a127ea.
fabpot
approved these changes
Oct 31, 2018
chalasr
approved these changes
Oct 31, 2018
nicolas-grekas
approved these changes
Oct 31, 2018
nicolas-grekas
approved these changes
Oct 31, 2018
2 tasks
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 1, 2018
…ethod for Request" (Tobion) This PR was merged into the 4.2-dev branch. Discussion ---------- Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request" This reverts commit 8a127ea. | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #26486 | License | MIT | Doc PR | As I said in #26486 (comment) and people wonder in https://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core. I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of `*/*` and this is what people usually need in REST APIs etc. But for now, we should revert it before it gets released like this. Commits ------- 397ed83 Revert "[HttpFoundation] Adds getAcceptableFormats() method for Request"
This was referenced Nov 3, 2018
Closed
Merged
This was referenced Nov 10, 2018
Closed
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Nov 11, 2018
…eptableFormat… (kunicmarko20) This PR was merged into the master branch. Discussion ---------- Revert "minor #9898 [HttpFoundation] Add info for getAcceptableFormat… This reverts commit fbca6db, because it was reverted in the core symfony/symfony#29047. closes #10656 Commits ------- 27967c2 Revert "minor #9898 [HttpFoundation] Add info for getAcceptableFormats() method (AndreiIgna)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8a127ea.
As I said in #26486 (comment) and people wonder in https://symfony.com/blog/new-in-symfony-4-2-acceptable-request-formats#comment-22747, I don't think this method clear and generic enough to be added to the core.
I can't see where I would possibly use this method. What would be useful is a similar method that accepts formats as argument and would return the ones that are acceptable according to the accept header. This would then allow to make use of
*/*and this is what people usually need in REST APIs etc.But for now, we should revert it before it gets released like this.