Skip to content

[TwigBridge] require the needed symfony/contracts package #29095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

[TwigBridge] require the needed symfony/contracts package #29095

merged 1 commit into from
Nov 6, 2018

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Nov 5, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #29086
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.2 milestone Nov 5, 2018
@nicolas-grekas
Copy link
Member

Shouldn't this be added to the bundle instead? The bridge doesn't force using the TranslationExtension - the bundle does. WDYT?

@xabbuh
Copy link
Member Author

xabbuh commented Nov 5, 2018

My reasoning would be that the extension was usable without installing any other package before and would now also break other potential consumers of it that do not use the bundle.

@nicolas-grekas
Copy link
Member

My reasoning would be that the extension was usable without installing any other package

symfony/translation was required, isn't it? and this one links to symfony/contracts in 4.2

@xabbuh
Copy link
Member Author

xabbuh commented Nov 5, 2018

we used strtr() as a fallback: https://github.com/symfony/symfony/blob/4.1/src/Symfony/Bridge/Twig/Extension/TranslationExtension.php#L94

@ro0NL
Copy link
Contributor

ro0NL commented Nov 5, 2018 •
edited
Loading

yes, twig bridge suggests: "symfony/translation": "For using the TranslationExtension".

IIUC the issues is we dont have symfony/translation and it fallbacks to the contract implementation.. but that's still a soft-dependency 🤔

edit: @xabbuh was faster :)

nicolas-grekas
nicolas-grekas approved these changes Nov 5, 2018
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

understood, thanks

@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 4400776 into symfony:master Nov 6, 2018
nicolas-grekas added a commit that referenced this pull request Nov 6, 2018
@nicolas-grekas
bug #29095 [TwigBridge] require the needed symfony/contracts package …
f9198c2 
…(xabbuh)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[TwigBridge] require the needed symfony/contracts package

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29086
| License       | MIT
| Doc PR        |

Commits
-------

4400776 require the needed symfony/contracts package
@xabbuh xabbuh deleted the issue-29086 branch November 6, 2018 16:02
@fabpot fabpot mentioned this pull request Nov 16, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
7 participants
@xabbuh @nicolas-grekas @ro0NL @OskarStark @derrabus @ogizanagi @carsonbot