Change button_widget class to btn-primary #29115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the method should return a bool, then the default value should be a bool too
…etBoolean (lyrixx) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- Since the method should return a bool, then the default value should be a bool too Commits ------- 1fa5a9a [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
xabbuh
reviewed
Nov 7, 2018
src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_4_layout.html.twig
Outdated
Show resolved
Hide resolved
|
@Nefast Can you take a look at the failing tests? |
|
@xabbuh fixed |
xabbuh
approved these changes
Nov 8, 2018
|
@Nefast Thanks for your fast reaction. Nice contribution. 👍 IMO this is a bugfix so I have updated the description accordingly. Don't worry about the target branch. We can rebase your changes on the right branch while merging. |
dunglas
approved these changes
Nov 8, 2018
…pe headers (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] replace any preexisting Content-Type headers | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#21204 | License | MIT | Doc PR | - Commits ------- de2ce58 [HttpFoundation] replace any preexisting Content-Type headers
* 2.8: [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean [HttpFoundation] replace any preexisting Content-Type headers
…ARS (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Since using it is not thread safe, let's not rely on it (already done in other places.) Commits ------- 21a909a [Dotenv] dont use getenv() to read SYMFONY_DOTENV_VARS
94e79ce to
59003bf
Compare
|
Thank you @Nefast. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2018
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29115). Discussion ---------- Change button_widget class to btn-primary FIX #29114 | Q | A | ------------- | --- | Branch? | master for features / 2.8 up to 4.1 for bug fixes <!-- see below --> | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29114 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> Change button_widget class to btn-primary in Bootstrap 4 twig template Commits ------- 59003bf Change button_widget class to btn-primary
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #29114
Change button_widget class to btn-primary in Bootstrap 4 twig template